From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJBru-0006JQ-J9 for qemu-devel@nongnu.org; Tue, 23 Jun 2009 15:41:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJBrp-0006Gw-G2 for qemu-devel@nongnu.org; Tue, 23 Jun 2009 15:41:21 -0400 Received: from [199.232.76.173] (port=37349 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJBrp-0006Gr-7M for qemu-devel@nongnu.org; Tue, 23 Jun 2009 15:41:17 -0400 Received: from verein.lst.de ([213.95.11.210]:34869) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MJBro-0005z0-Lg for qemu-devel@nongnu.org; Tue, 23 Jun 2009 15:41:17 -0400 Date: Tue, 23 Jun 2009 21:41:14 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs Message-ID: <20090623194114.GA11045@lst.de> References: <1245763236-23464-1-git-send-email-avi@redhat.com> <20090623165006.GC27211@lst.de> <4A41095D.7070608@redhat.com> <20090623182622.GA5804@lst.de> <4A411F9B.5020508@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A411F9B.5020508@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Christoph Hellwig , qemu-devel@nongnu.org On Tue, Jun 23, 2009 at 09:31:55PM +0300, Avi Kivity wrote: > I meant in an omg we have to look at all the consequences way rather > than byte count. This patch is somewhat less local. My patch makes sure a re-used acb is in the same state as a newly allocated one. I think that's much more sensible than messing around with some state during freeing some acbs.