From: Jamie Lokier <jamie@shareable.org>
To: "Andreas Färber" <andreas.faerber@web.de>
Cc: programmingkidx@gmail.com, "François Revol" <revol@free.fr>,
"Avi Kivity" <avi@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC
Date: Wed, 24 Jun 2009 19:25:07 +0100 [thread overview]
Message-ID: <20090624182507.GL14121@shareable.org> (raw)
In-Reply-To: <7B46D10B-ECDB-4AB7-B9CD-59F7A92886BE@web.de>
Andreas Färber wrote:
>
> Am 21.06.2009 um 01:25 schrieb Jamie Lokier:
>
> >François Revol wrote:
> >>>On 06/20/2009 05:31 PM, Anthony Liguori wrote:
> >>>>Please [...] use C-style comments instead
> >>>>of C++ style comments. [...]
> >>>
> >>>What do we have against C++ style comments?
> >>
> >>They are not valid in C code :P
> >
> >Wrong.
> >
> >Valid in GNU C for about 14 years, and ANSI/ISO C for about 10
> >years...
> >
> >I'll be surprised if any C compiler used on any open source operating
> >system, or any major commercial C compiler, doesn't accept them.
>
> Gladly even ten-year-old GCC 2.95.x supports 'em. But even a recent
> GCC does not when compiled with -ansi, which is why system headers
> still mustn't use them.
This is wrong too. They can be used in system headers.
"gcc -ansi -pedantic -Wall -Werror" accepts C99 comments in system
headers.
It just complains about them in your own code, since you asked it to. :-)
-- Jamie
next prev parent reply other threads:[~2009-06-24 18:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 2:22 [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC m a
2009-06-20 14:31 ` Anthony Liguori
2009-06-20 18:59 ` Avi Kivity
2009-06-20 19:03 ` François Revol
2009-06-20 19:15 ` Avi Kivity
2009-06-20 23:25 ` Jamie Lokier
2009-06-21 10:01 ` Andreas Färber
2009-06-24 18:25 ` Jamie Lokier [this message]
2009-06-24 18:54 ` Andreas Färber
2009-06-24 18:59 ` Filip Navara
2009-06-24 19:08 ` Jamie Lokier
2009-06-20 20:46 ` Anthony Liguori
2009-06-21 9:01 ` Avi Kivity
2009-06-20 19:16 ` Christoph Hellwig
2009-06-20 23:30 ` Jamie Lokier
2009-06-20 23:37 ` Anthony Liguori
2009-06-21 0:41 ` G 3
2009-06-24 18:27 ` Jamie Lokier
2009-06-21 0:46 ` G 3
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090624182507.GL14121@shareable.org \
--to=jamie@shareable.org \
--cc=andreas.faerber@web.de \
--cc=avi@redhat.com \
--cc=programmingkidx@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=revol@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).