From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MJXq1-0003yK-VH for qemu-devel@nongnu.org; Wed, 24 Jun 2009 15:08:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MJXpx-0003ra-D7 for qemu-devel@nongnu.org; Wed, 24 Jun 2009 15:08:53 -0400 Received: from [199.232.76.173] (port=47591 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MJXpx-0003rR-80 for qemu-devel@nongnu.org; Wed, 24 Jun 2009 15:08:49 -0400 Received: from mail2.shareable.org ([80.68.89.115]:45981) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MJXpw-0004lK-Bq for qemu-devel@nongnu.org; Wed, 24 Jun 2009 15:08:48 -0400 Date: Wed, 24 Jun 2009 20:08:44 +0100 From: Jamie Lokier Subject: Re: [Qemu-devel] [PATCH] replace O_SYNC with O_FSYNC Message-ID: <20090624190844.GS14121@shareable.org> References: <4A3D3189.1080307@redhat.com> <10665282192-BeMail@laptop> <20090620232508.GA29958@shareable.org> <7B46D10B-ECDB-4AB7-B9CD-59F7A92886BE@web.de> <20090624182507.GL14121@shareable.org> <5b31733c0906241159j57fcea05vad21db3a29e32935@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5b31733c0906241159j57fcea05vad21db3a29e32935@mail.gmail.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Filip Navara Cc: programmingkidx@gmail.com, Andreas =?iso-8859-1?Q?F=E4rber?= , =?iso-8859-1?Q?Fran=E7ois?= Revol , Avi Kivity , qemu-devel@nongnu.org Filip Navara wrote: > On Wed, Jun 24, 2009 at 8:54 PM, Andreas Färber wrote: > > > > Am 24.06.2009 um 20:25 schrieb Jamie Lokier: > > > >> Andreas Färber wrote: > >>> > >>> Am 21.06.2009 um 01:25 schrieb Jamie Lokier: > >>> > >>>> François Revol wrote: > >>>>>> > >>>>>> On 06/20/2009 05:31 PM, Anthony Liguori wrote: > >>>>>>> > >>>>>>> Please [...] use C-style comments instead > >>>>>>> of C++ style comments. [...] > >>>>>> > >>>>>> What do we have against C++ style comments? > >>>>> > >>>>> They are not valid in C code :P > >>>> > >>>> Wrong. > >>>> > >>>> Valid in GNU C for about 14 years, and ANSI/ISO C for about 10 > >>>> years... > >>>> > >>>> I'll be surprised if any C compiler used on any open source operating > >>>> system, or any major commercial C compiler, doesn't accept them. > >>> > >>> Gladly even ten-year-old GCC 2.95.x supports 'em. But even a recent > >>> GCC does not when compiled with -ansi, which is why system headers > >>> still mustn't use them. > >> > >> This is wrong too.  They can be used in system headers. > > > > No, that is wrong. freetype2 definitely complained when Haiku had C99 > > comments in its POSIX system headers. ;) > > #pragma GCC system_header GCC has a notion of certain directories being system header directories. So you don't need #pragma for headers in those, and if freetype2 was installed in them, that should have worked. But if you install those headers in other places, then it doesn't treat them as system headers and becomes more strict about the language. You can add more system header directories, but of course (nearly) everyone uses -Idir to add directories as that's well known and portable. -- Jamie