From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MJk94-0004wJ-HI
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 04:17:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MJk90-0004rc-H2
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 04:17:22 -0400
Received: from [199.232.76.173] (port=41178 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MJk90-0004rS-Cw
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 04:17:18 -0400
Received: from mx2.redhat.com ([66.187.237.31]:42304)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rjones@redhat.com>) id 1MJk8z-00023z-WA
	for qemu-devel@nongnu.org; Thu, 25 Jun 2009 04:17:18 -0400
Date: Thu, 25 Jun 2009 09:17:11 +0100
From: "Richard W.M. Jones" <rjones@redhat.com>
Subject: Re: [Qemu-devel] Regression opening read-only cdroms
Message-ID: <20090625081711.GA27401@amd.home.annexia.org>
References: <4A37896C.8050208@redhat.com>
	<20090616143259.GA29040@shareable.org>
	<20090618123759.GA7041@amd.home.annexia.org>
	<20090624202353.GV14121@shareable.org>
	<20090624224353.GA24810@amd.home.annexia.org>
	<20090625005032.GJ14121@shareable.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090625005032.GJ14121@shareable.org>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jamie Lokier <jamie@shareable.org>
Cc: qemu-devel <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>, Christoph Hellwig <hch@lst.de>

On Thu, Jun 25, 2009 at 01:50:32AM +0100, Jamie Lokier wrote:
> Richard W.M. Jones wrote:
> > On Wed, Jun 24, 2009 at 09:23:53PM +0100, Jamie Lokier wrote:
> > > It'd be nice to enforce it, instead of depending on good behaviour
> > > from the guest.
> > 
> > Right - but in libguestfs everything is controlled by the host so we
> > can rely on good behaviour in our case.
> 
> In that case, why do you need the ",snapshot=on"?

Did I say that?  I meant that we use that only for read-only access to
hard drives, not for CD-ROMs.  Here's the actual code:

http://git.et.redhat.com/?p=libguestfs.git;a=blob;f=src/guestfs.c;h=fdf5cd369842557b744bac2a80fdbd97fa4e8d60;hb=13229b1d54c03be098ab75e6d451b5b46a98550d#l661

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 75 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora