From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MKCQb-000685-IG
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 10:29:21 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MKCQW-00066V-RS
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 10:29:20 -0400
Received: from [199.232.76.173] (port=51750 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MKCQW-00066S-ID
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 10:29:16 -0400
Received: from mx2.redhat.com ([66.187.237.31]:53683)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MKCQW-0004XG-55
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 10:29:16 -0400
Date: Fri, 26 Jun 2009 17:26:35 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090626142635.GD5939@redhat.com>
References: <cover.1245594586.git.mst@redhat.com>
	<20090621164954.GF10164@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090621164954.GF10164@redhat.com>
Subject: [Qemu-devel] Re: [PATCHv6 05/12] qemu/pci: MSI-X support functions
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>, Avi Kivity <avi@redhat.com>, qemu-devel@nongnu.org, Carsten Otte <cotte@de.ibm.com>, kvm@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>, virtualization@lists.linux-foundation.org, Christian Borntraeger <borntraeger@de.ibm.com>, Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <anthony@codemonkey.ws>, Glauber Costa <glommer@redhat.com>

On Sun, Jun 21, 2009 at 07:49:54PM +0300, Michael S. Tsirkin wrote:
> +    dev->msix_mmio_index = cpu_register_io_memory(0, msix_mmio_read,
> +                                                  msix_mmio_write, dev);


The signature for cpu_register_io_memory changed meanwhile so this now
needs to be:

+    dev->msix_mmio_index = cpu_register_io_memory(msix_mmio_read,
+                                                  msix_mmio_write, dev);

Anthony, I guess you figured this out, or do you want me to respin the series
with this minor fix?

-- 
MST