From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MKFeO-0001zD-LS for qemu-devel@nongnu.org; Fri, 26 Jun 2009 13:55:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MKFeK-0001tP-4d for qemu-devel@nongnu.org; Fri, 26 Jun 2009 13:55:48 -0400 Received: from [199.232.76.173] (port=54152 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MKFeJ-0001t1-Tu for qemu-devel@nongnu.org; Fri, 26 Jun 2009 13:55:43 -0400 Received: from verein.lst.de ([213.95.11.210]:47866) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MKFeJ-0003rU-Ad for qemu-devel@nongnu.org; Fri, 26 Jun 2009 13:55:43 -0400 Date: Fri, 26 Jun 2009 19:55:38 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] Substitute O_SYNC with O_FSYNC in block/raw-posix.c Message-ID: <20090626175538.GA4077@lst.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: G 3 Cc: qemu-devel@nongnu.org On Thu, Jun 25, 2009 at 08:59:35PM -0400, G 3 wrote: > This patch will allow the file block/raw-posix.c to compile on gcc 3.3 > on Mac OS 10.3. Since the O_SYNC symbol is missing on this version of > the Mac OS, O_FSYNC will be used in its place. Same comment about the zero as last time still applies. Also the look of this is really ugly as you just deinfe O_SYNC only for it to substitute for O_DSYNC a littler later, with two comments that together are rather confusing about macos..