From: Nathan Froyd <froydnj@codesourcery.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: Cache refcount blocks during snapshot creation
Date: Fri, 26 Jun 2009 11:48:06 -0700 [thread overview]
Message-ID: <20090626184806.GE1119@codesourcery.com> (raw)
In-Reply-To: <1246040378-4134-1-git-send-email-kwolf@redhat.com>
On Fri, Jun 26, 2009 at 08:19:38PM +0200, Kevin Wolf wrote:
> + if (s->refcount_block_cache_offset == 0) {
> + return 0;
> + }
> +
> + if (bdrv_pwrite(s->hd, s->refcount_block_cache_offset,
> + s->refcount_block_cache, size) != size)
> + {
Nit: bad formatting for opening brace here.
-Nathan
next prev parent reply other threads:[~2009-06-26 18:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-26 18:19 [Qemu-devel] [PATCH] qcow2: Cache refcount blocks during snapshot creation Kevin Wolf
2009-06-26 18:48 ` Nathan Froyd [this message]
2009-06-27 9:01 ` Kevin Wolf
2009-06-27 11:21 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090626184806.GE1119@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).