From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MKGT8-0003Vq-93
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 14:48:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MKGT3-0003NN-K6
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 14:48:13 -0400
Received: from [199.232.76.173] (port=52980 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MKGT3-0003ND-HM
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 14:48:09 -0400
Received: from mx20.gnu.org ([199.232.41.8]:4431)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <froydnj@codesourcery.com>)
	id 1MKGT3-000481-7C
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 14:48:09 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <froydnj@codesourcery.com>) id 1MKGT2-00065a-2u
	for qemu-devel@nongnu.org; Fri, 26 Jun 2009 14:48:08 -0400
Date: Fri, 26 Jun 2009 11:48:06 -0700
From: Nathan Froyd <froydnj@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] qcow2: Cache refcount blocks during snapshot
	creation
Message-ID: <20090626184806.GE1119@codesourcery.com>
References: <1246040378-4134-1-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1246040378-4134-1-git-send-email-kwolf@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On Fri, Jun 26, 2009 at 08:19:38PM +0200, Kevin Wolf wrote:
> +    if (s->refcount_block_cache_offset == 0) {
> +        return 0;
> +    }
> +
> +    if (bdrv_pwrite(s->hd, s->refcount_block_cache_offset,
> +            s->refcount_block_cache, size) != size)
> +    {

Nit: bad formatting for opening brace here.

-Nathan