From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Filip Navara <filip.navara@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] Get rid of temporary variable cache.
Date: Mon, 29 Jun 2009 19:34:55 +0100 [thread overview]
Message-ID: <200906291934.56186.paul@codesourcery.com> (raw)
On Monday 29 June 2009, Filip Navara wrote:
> The temporary variable cache actually hurts TCG more than it helps.
> Empirical results show that when running the Dhrystone benchmark with this
> patch improves the speed by about 2%.
I find it hard to believe this patch has any significant effect on runtime,
other than random variation. My guess is it spends almost all of its time in a
few guest loops, and no time doing translation. I'd expect the generated code
should be the same before and after.
I'm not saying this patch is a bad idea (new_tmp/dead_tmp predate
tcg_temp_free and are now redundant), just that I don't believe your benchmark
results.
Paul
next reply other threads:[~2009-06-29 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 18:34 Paul Brook [this message]
2009-06-29 18:57 ` [Qemu-devel] [PATCH 2/3] Get rid of temporary variable cache Filip Navara
-- strict thread matches above, loose matches on Subject: below --
2009-06-29 17:49 Filip Navara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906291934.56186.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=filip.navara@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).