qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aba800a] qemu/virtio: MSI-X support in virtio PCI
Date: Tue, 30 Jun 2009 13:25:52 +0300	[thread overview]
Message-ID: <20090630102552.GE29725@redhat.com> (raw)
In-Reply-To: <761ea48b0906292334o1d5ee2c2r17337d01bd50014c@mail.gmail.com>

On Tue, Jun 30, 2009 at 08:34:50AM +0200, Laurent Desnogues wrote:
> On Tue, Jun 30, 2009 at 2:57 AM, Anthony Liguori<aliguori@us.ibm.com> wrote:
> > From: Michael S. Tsirkin <mst@redhat.com>
> >
> > This enables actual support for MSI-X in virtio PCI.
> > First user will be virtio-net.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> [...]
> > diff --git a/rules.mak b/rules.mak
> > index 8d6d96e..defee1d 100644
> > --- a/rules.mak
> > +++ b/rules.mak
> > @@ -1,6 +1,6 @@
> >
> >  %.o: %.c
> > -       $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
> > +       $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -Wno-error=uninitialized -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
> 
> -Wno-error=uninitialized is a rather recent addition to gcc and
> will probably break compilation on many systems.
> 
> 
> Laurent

Yes, apparently, this was added with gcc 4.2.0, released in May 2007.
Maybe we need configure to figure this out.

-- 
MST

  reply	other threads:[~2009-06-30 10:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200906300055.n5U0tACD013302@d03av01.boulder.ibm.com>
2009-06-30  6:34 ` [Qemu-devel] Re: [Qemu-commits] [COMMIT aba800a] qemu/virtio: MSI-X support in virtio PCI Laurent Desnogues
2009-06-30 10:25   ` Michael S. Tsirkin [this message]
2009-06-30 13:10     ` Anthony Liguori
2009-06-30 13:14       ` Anthony Liguori
2009-06-30 13:19       ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090630102552.GE29725@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=laurent.desnogues@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).