From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLaXo-0005Cl-Pd
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 06:26:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLaXj-00055w-BR
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 06:26:31 -0400
Received: from [199.232.76.173] (port=48664 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLaXj-00055T-3B
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 06:26:27 -0400
Received: from mx2.redhat.com ([66.187.237.31]:47797)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MLaXi-0004FB-JL
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 06:26:26 -0400
Date: Tue, 30 Jun 2009 13:25:52 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aba800a] qemu/virtio:
	MSI-X support in virtio PCI
Message-ID: <20090630102552.GE29725@redhat.com>
References: <200906300055.n5U0tACD013302@d03av01.boulder.ibm.com>
	<761ea48b0906292334o1d5ee2c2r17337d01bd50014c@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <761ea48b0906292334o1d5ee2c2r17337d01bd50014c@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Tue, Jun 30, 2009 at 08:34:50AM +0200, Laurent Desnogues wrote:
> On Tue, Jun 30, 2009 at 2:57 AM, Anthony Liguori<aliguori@us.ibm.com> w=
rote:
> > From: Michael S. Tsirkin <mst@redhat.com>
> >
> > This enables actual support for MSI-X in virtio PCI.
> > First user will be virtio-net.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> [...]
> > diff --git a/rules.mak b/rules.mak
> > index 8d6d96e..defee1d 100644
> > --- a/rules.mak
> > +++ b/rules.mak
> > @@ -1,6 +1,6 @@
> >
> > =A0%.o: %.c
> > - =A0 =A0 =A0 $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -c -o =
$@ $<," =A0CC =A0 =A0$(TARGET_DIR)$@")
> > + =A0 =A0 =A0 $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werro=
r -Wno-error=3Duninitialized -c -o $@ $<," =A0CC =A0 =A0$(TARGET_DIR)$@")
>=20
> -Wno-error=3Duninitialized is a rather recent addition to gcc and
> will probably break compilation on many systems.
>=20
>=20
> Laurent

Yes, apparently, this was added with gcc 4.2.0, released in May 2007.
Maybe we need configure to figure this out.

--=20
MST