From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLcF0-00077B-Si for qemu-devel@nongnu.org; Tue, 30 Jun 2009 08:15:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLcF0-00076x-BH for qemu-devel@nongnu.org; Tue, 30 Jun 2009 08:15:14 -0400 Received: from [199.232.76.173] (port=35602 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLcF0-00076u-4C for qemu-devel@nongnu.org; Tue, 30 Jun 2009 08:15:14 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37283) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MLcEz-0003fF-JT for qemu-devel@nongnu.org; Tue, 30 Jun 2009 08:15:13 -0400 Date: Tue, 30 Jun 2009 15:12:40 +0300 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] [PATCH] move -Wno-error=uninitialized to configure Message-ID: <20090630121240.GA1227@redhat.com> References: <20090630113949.GA32364@redhat.com> <200906301309.27397.paul@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200906301309.27397.paul@codesourcery.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: Laurent Desnogues , Anthony Liguori , qemu-devel@nongnu.org On Tue, Jun 30, 2009 at 01:07:34PM +0100, Paul Brook wrote: > On Tuesday 30 June 2009, Michael S. Tsirkin wrote: > > Move -Wno-error=uninitialized out of rules.mak and into configure. Only > > use it if supported by compiler. > > Why? Shouldn't we be fixing the uninitialized variables? > > Paul gcc's algorithm for detecting uninitialized variables is famously unreliable. Just scattering '= 0' around the code masks the warning but hides the fact that application logic might still be broken. -- MST