From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLbSw-0003Ve-MU
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 07:25:35 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLbSq-0003U6-Ce
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 07:25:32 -0400
Received: from [199.232.76.173] (port=39937 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLbSp-0003Ty-4S
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 07:25:27 -0400
Received: from mx20.gnu.org ([199.232.41.8]:15018)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MLbSo-00077f-JX
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 07:25:26 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MLbSn-0002LH-QQ
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 07:25:26 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 6/8] qdev/pci: misc fixes.
Date: Tue, 30 Jun 2009 12:25:22 +0100
References: <1246353962-32308-1-git-send-email-kraxel@redhat.com>
	<1246353962-32308-7-git-send-email-kraxel@redhat.com>
In-Reply-To: <1246353962-32308-7-git-send-email-kraxel@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906301225.23268.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>

On Tuesday 30 June 2009, Gerd Hoffmann wrote:
> -    register_savevm("PCIBUS", nbus++, 1, pcibus_save, pcibus_load, bus);
> +    register_savevm("PCIBUS", bus->qbus.busnr, 1, pcibus_save,
> pcibus_load, bus);

This is wrong. In principle there may be many different PCI domains with 
overlapping bus numbers.

Paul