From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLdGB-0008UC-IF
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:20:31 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLdG6-0008KP-Vg
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:20:31 -0400
Received: from [199.232.76.173] (port=41160 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLdG6-0008Jx-PZ
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:20:26 -0400
Received: from mx2.redhat.com ([66.187.237.31]:35103)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MLdG6-0000Pa-BP
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 09:20:26 -0400
Date: Tue, 30 Jun 2009 16:19:52 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [Qemu-commits] [COMMIT aba800a] qemu/virtio:
	MSI-X support in virtio PCI
Message-ID: <20090630131952.GB10413@redhat.com>
References: <200906300055.n5U0tACD013302@d03av01.boulder.ibm.com>
	<761ea48b0906292334o1d5ee2c2r17337d01bd50014c@mail.gmail.com>
	<20090630102552.GE29725@redhat.com> <4A4A0EDF.9040207@us.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A4A0EDF.9040207@us.ibm.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, qemu-devel@nongnu.org

On Tue, Jun 30, 2009 at 08:10:55AM -0500, Anthony Liguori wrote:
> Michael S. Tsirkin wrote:
>> On Tue, Jun 30, 2009 at 08:34:50AM +0200, Laurent Desnogues wrote:
>>   
>>> On Tue, Jun 30, 2009 at 2:57 AM, Anthony Liguori<aliguori@us.ibm.com> wrote:
>>>     
>>>> From: Michael S. Tsirkin <mst@redhat.com>
>>>>
>>>> This enables actual support for MSI-X in virtio PCI.
>>>> First user will be virtio-net.
>>>>
>>>> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>>>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>>>       
>>> [...]
>>>     
>>>> diff --git a/rules.mak b/rules.mak
>>>> index 8d6d96e..defee1d 100644
>>>> --- a/rules.mak
>>>> +++ b/rules.mak
>>>> @@ -1,6 +1,6 @@
>>>>
>>>>  %.o: %.c
>>>> -       $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
>>>> +       $(call quiet-command,$(CC) $(CPPFLAGS) $(CFLAGS) -Werror -Wno-error=uninitialized -c -o $@ $<,"  CC    $(TARGET_DIR)$@")
>>>>       
>>> -Wno-error=uninitialized is a rather recent addition to gcc and
>>> will probably break compilation on many systems.
>>>
>>>     
>
> Adding something like this in the middle of a patch, in the middle of a  
> big series, is also a really bad thing to do.

I know. I think I just mistakenly did "git commit -a" at some point,
and it slipped through review.

> If you want to change  
> build arguments, it should be a separate patch.
>
> I removed this.  There are no warnings with my GCC.  You can submit  
> follow up patches trying to make a case for different ways to handle  
> this but please separate this sort of stuff out in the future.
>
> Regards,
>
> Anthony Liguori