From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MLgeI-0002ey-MG for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:57:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MLgeD-0002cI-HC for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:57:37 -0400 Received: from [199.232.76.173] (port=52990 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MLgeD-0002cB-B3 for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:57:33 -0400 Received: from verein.lst.de ([213.95.11.210]:50041) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MLgeC-0007jL-Pj for qemu-devel@nongnu.org; Tue, 30 Jun 2009 12:57:33 -0400 Date: Tue, 30 Jun 2009 18:57:31 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev Message-ID: <20090630165731.GA1593@lst.de> References: <1246369037-2845-1-git-send-email-kwolf@redhat.com> <20090630165043.GA1159@lst.de> <4A4A4371.8020409@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A4A4371.8020409@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Tue, Jun 30, 2009 at 06:55:13PM +0200, Kevin Wolf wrote: > Christoph Hellwig schrieb: > > On Tue, Jun 30, 2009 at 03:37:17PM +0200, Kevin Wolf wrote: > >> Pass is_write = 1 to qcow_aio_setup when writing. > > > > Looks correct, sorry for introducing this. > > > > Maybe we should add symbolic names for READ/WRITE in another patch to > > make this more easily spottable? > > I'd expect we'll not see such things in the same place again, but > symbolic constants are always better. Are you going to prepare a patch? I'll put it on my todo list, after some higher priority items :)