* [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev
@ 2009-06-30 13:37 Kevin Wolf
2009-06-30 16:50 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Wolf @ 2009-06-30 13:37 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf
Pass is_write = 1 to qcow_aio_setup when writing.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 55a68a6..7fc85ae 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -723,7 +723,7 @@ static BlockDriverAIOCB *qcow_aio_writev(BlockDriverState *bs,
s->cluster_cache_offset = -1; /* disable compressed cache */
- acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 0);
+ acb = qcow_aio_setup(bs, sector_num, qiov, nb_sectors, cb, opaque, 1);
if (!acb)
return NULL;
--
1.6.0.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev
2009-06-30 13:37 [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev Kevin Wolf
@ 2009-06-30 16:50 ` Christoph Hellwig
2009-06-30 16:55 ` Kevin Wolf
0 siblings, 1 reply; 4+ messages in thread
From: Christoph Hellwig @ 2009-06-30 16:50 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
On Tue, Jun 30, 2009 at 03:37:17PM +0200, Kevin Wolf wrote:
> Pass is_write = 1 to qcow_aio_setup when writing.
Looks correct, sorry for introducing this.
Maybe we should add symbolic names for READ/WRITE in another patch to
make this more easily spottable?
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev
2009-06-30 16:50 ` Christoph Hellwig
@ 2009-06-30 16:55 ` Kevin Wolf
2009-06-30 16:57 ` Christoph Hellwig
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Wolf @ 2009-06-30 16:55 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: qemu-devel
Christoph Hellwig schrieb:
> On Tue, Jun 30, 2009 at 03:37:17PM +0200, Kevin Wolf wrote:
>> Pass is_write = 1 to qcow_aio_setup when writing.
>
> Looks correct, sorry for introducing this.
>
> Maybe we should add symbolic names for READ/WRITE in another patch to
> make this more easily spottable?
I'd expect we'll not see such things in the same place again, but
symbolic constants are always better. Are you going to prepare a patch?
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev
2009-06-30 16:55 ` Kevin Wolf
@ 2009-06-30 16:57 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2009-06-30 16:57 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
On Tue, Jun 30, 2009 at 06:55:13PM +0200, Kevin Wolf wrote:
> Christoph Hellwig schrieb:
> > On Tue, Jun 30, 2009 at 03:37:17PM +0200, Kevin Wolf wrote:
> >> Pass is_write = 1 to qcow_aio_setup when writing.
> >
> > Looks correct, sorry for introducing this.
> >
> > Maybe we should add symbolic names for READ/WRITE in another patch to
> > make this more easily spottable?
>
> I'd expect we'll not see such things in the same place again, but
> symbolic constants are always better. Are you going to prepare a patch?
I'll put it on my todo list, after some higher priority items :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-06-30 16:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-30 13:37 [Qemu-devel] [PATCH] qcow1: Fix qcow_aio_writev Kevin Wolf
2009-06-30 16:50 ` Christoph Hellwig
2009-06-30 16:55 ` Kevin Wolf
2009-06-30 16:57 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).