From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLh1L-0006wj-F9
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 13:21:27 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLh1G-0006jU-N5
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 13:21:26 -0400
Received: from [199.232.76.173] (port=51526 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLh1G-0006jB-FN
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 13:21:22 -0400
Received: from mx20.gnu.org ([199.232.41.8]:31181)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MLh1G-0002sV-8Z
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 13:21:22 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MLh1F-0008Rp-AM
	for qemu-devel@nongnu.org; Tue, 30 Jun 2009 13:21:21 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 4/8] qdev/core: bus list
Date: Tue, 30 Jun 2009 18:21:17 +0100
References: <1246353962-32308-1-git-send-email-kraxel@redhat.com>
	<200906301218.35086.paul@codesourcery.com>
	<87k52t8xvk.fsf@pike.pond.sub.org>
In-Reply-To: <87k52t8xvk.fsf@pike.pond.sub.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906301821.18245.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>

On Tuesday 30 June 2009, Markus Armbruster wrote:
> Paul Brook <paul@codesourcery.com> writes:
> > On Tuesday 30 June 2009, Gerd Hoffmann wrote:
> >>  * maintain a list of busses.
> >>  * maintain bus numbers.
> >>  * add function to find busses by type / name / number.
> >>  * add monitor command to list busses.
> >
> > I still object to this patch. Busses should be identified by their
> > location in the tree, not by number.
> >
> > Paul
>
> Location in the tree can be uniquely identified by a number.  Handy when
> all you want is enumerate the buses, and you don't really care where
> they're hanging out in the tree.  Why should something like that not be
> done?

The address of the BusState is also a locally unique identifier. That doesn't 
mean it's a good thing to expose to the user.

Paul