From: Bique Alexandre <alexandre.bique@citrix.com>
To: Christoph Hellwig <hch@lst.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] ATAPI pass through
Date: Tue, 30 Jun 2009 18:55:42 +0100 [thread overview]
Message-ID: <200906301855.42855.alexandre.bique@citrix.com> (raw)
In-Reply-To: <20090630170100.GA1678@lst.de>
On Tuesday 30 June 2009 18:01:00 Christoph Hellwig wrote:
> On Tue, Jun 30, 2009 at 04:34:53PM +0100, Bique Alexandre wrote:
> > - I exported the data structure BDRVRawState from raw-posix.c in
> > raw-posix.h, because I use the file descriptor of the bsg device to poll,
> > write and read. Maybe there is a better solution, but I didn't find what
> > I was looking for in block.h.
>
> The way we do scsi passthrough (and ATAPI really just is SCSI
> passthrough over ATA with a slightly special command set) is to call
> into the ioctl/aio_ioctl methods of the block driver and let that do
> the actual I/O. I think your patch would be simpler and cleaner by
> following that model
I can switch to aio_ioctl, and use CDROM_SEND_PACKET ioctl.
Is it possible to send multiple requests at the same time with aio_ioctl ?
When CONFIG_AIO is not available ?
Thanks.
--
Alexandre Bique
next prev parent reply other threads:[~2009-06-30 17:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-30 15:34 [Qemu-devel] [PATCH] ATAPI pass through Bique Alexandre
2009-06-30 16:26 ` Kevin Wolf
2009-06-30 18:10 ` Bique Alexandre
2009-07-01 6:57 ` Alexander Graf
2009-07-01 8:44 ` Christoph Hellwig
2009-07-01 9:36 ` Paul Brook
2009-07-01 11:29 ` Christoph Hellwig
2009-06-30 17:01 ` Christoph Hellwig
2009-06-30 17:55 ` Bique Alexandre [this message]
2009-07-01 8:43 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906301855.42855.alexandre.bique@citrix.com \
--to=alexandre.bique@citrix.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).