From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MLvRD-0000cV-5l
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 04:45:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MLvR8-0000c1-Lt
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 04:45:06 -0400
Received: from [199.232.76.173] (port=36708 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MLvR8-0000by-Iq
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 04:45:02 -0400
Received: from verein.lst.de ([213.95.11.210]:33773)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MLvR8-0007wg-2Z
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 04:45:02 -0400
Date: Wed, 1 Jul 2009 10:44:59 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] ATAPI pass through
Message-ID: <20090701084459.GA3079@lst.de>
References: <200906301634.53197.alexandre.bique@citrix.com>
	<4A4A3CB7.8090309@redhat.com>
	<0B4B4929-9F33-4F87-A1D3-16D56661E84B@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0B4B4929-9F33-4F87-A1D3-16D56661E84B@suse.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Bique Alexandre <alexandre.bique@citrix.com>

On Wed, Jul 01, 2009 at 08:57:37AM +0200, Alexander Graf wrote:
> But last time I checked, we had a cdrom emulation in scsi-disk.c _and_  
> in ide.c.
> 
> I personally see no reason for that. Why can't we just have an atapi  
> emulation layer in ide.c and use whatever scsi backends we have? That  
> way, we'd only need to implement cd-rom and scsi passthrough once and  
> have it available either via SCSI or via ATAPI.

That would be best.  Note that we don't implement SCSI passthrough in
scsi-disk.c but rather in scsi-generic.c.  But being able to attach
both of them to ata.c using an ATAPI shim would indeed be best.