From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MM0SZ-0002C5-9x
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 10:06:51 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MM0SU-00027j-Lf
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 10:06:50 -0400
Received: from [199.232.76.173] (port=44983 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MM0SU-00027g-IE
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 10:06:46 -0400
Received: from one.firstfloor.org ([213.235.205.2]:44186)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <andi@firstfloor.org>) id 1MM0ST-0001IS-UH
	for qemu-devel@nongnu.org; Wed, 01 Jul 2009 10:06:46 -0400
Date: Wed, 1 Jul 2009 16:06:44 +0200
From: Andi Kleen <andi@firstfloor.org>
Subject: Re: [Qemu-devel] [PATCH] Allow setting qemu process name
Message-ID: <20090701140644.GV6760@one.firstfloor.org>
References: <20090701093251.GA12447@basil.fritz.box>
	<4A4B64B2.3040106@codemonkey.ws>
	<20090701134344.GT6760@one.firstfloor.org>
	<4A4B6B5B.5000106@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A4B6B5B.5000106@codemonkey.ws>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Andi Kleen <andi@firstfloor.org>, qemu-devel@nongnu.org

On Wed, Jul 01, 2009 at 08:57:47AM -0500, Anthony Liguori wrote:
> Andi Kleen wrote:
> >On Wed, Jul 01, 2009 at 08:29:22AM -0500, Anthony Liguori wrote:
> >  
> >It's only default with -name. I don't think anyone would look through
> >/proc matching for process names, that would be too broken anyways.
> >If they look through ps ax they would still work.
> >  
> 
> If someone has a script today that uses top -n 1 | grep 
> qemu-system-x86_64 that script will break.

That would already break if qemu-system-x86_64 is by chance not in 
the ~20 or so processes that take the most CPU time. That is what I meant
with already broken. I consider it very likely that the scripts
all use ps at least, which is not affected.

-Andi
-- 
ak@linux.intel.com -- Speaking for myself only.