From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MM5WD-0005ie-9n for qemu-devel@nongnu.org; Wed, 01 Jul 2009 15:30:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MM5W8-0005ga-3D for qemu-devel@nongnu.org; Wed, 01 Jul 2009 15:30:56 -0400 Received: from [199.232.76.173] (port=53264 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MM5W7-0005gR-Sh for qemu-devel@nongnu.org; Wed, 01 Jul 2009 15:30:51 -0400 Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]:30505) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MM5W7-0003N2-Bv for qemu-devel@nongnu.org; Wed, 01 Jul 2009 15:30:51 -0400 Received: from aamtaout04-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout02-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090701193044.JSNP6611.mtaout02-winn.ispmail.ntl.com@aamtaout04-winn.ispmail.ntl.com> for ; Wed, 1 Jul 2009 20:30:44 +0100 Received: from miranda.arrow ([213.107.24.213]) by aamtaout04-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090701193044.UNJX22934.aamtaout04-winn.ispmail.ntl.com@miranda.arrow> for ; Wed, 1 Jul 2009 20:30:44 +0100 Received: from sdb by miranda.arrow with local (Exim 4.63) (envelope-from ) id 1MM5Vu-00030o-Dz for qemu-devel@nongnu.org; Wed, 01 Jul 2009 20:30:38 +0100 Date: Wed, 1 Jul 2009 20:30:38 +0100 From: Stuart Brady Subject: Re: [Qemu-devel] Re: [PATCH 09/13] TARGET_ARCH2 is already known at configure time and it is called target_cpu Remove re-construction in Makefile.target Message-ID: <20090701193037.GA11528@miranda.arrow> References: <3d7905b5538d8d8787c8de4ae0486b849063e4cd.1246466962.git.quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Wed, Jul 01, 2009 at 08:21:12PM +0200, Juan Quintela wrote: > TARGET_BASE_ARCH: architecture name (mips, sparc, ppc) > TARGET_ARCH: Actual architecture > TARGET_SUBARCH: change about TARGET_ARCH (sparc32plus, little/big endian > variants) (was TARGET_ARCH2 and target_cpu) > TARGET_ABI: call ABI for this TARGET_SUBARCH > cpu = canonical name for the cpu, not sure how to relate this one with ARCH > ARCH: where are we building, it is always the same than 'cpu' on > configure, it is only used on the Makefiles, but I would preffer > to only use one name for the same meaning. Perhaps TARGET_CPU as the 'CPU architecture' (i.e. the name in the target-* directory), and TARGET_ARCH as the 'subarch' (i.e. taking big vs little-endian and 32 vs 64-bit into account)? BTW, the handling of these definitions is duplicated in the configure script for config.h and config.mak, and it'd be good to fix that. I think it might be nicer to specify target_bigendian in the same way that target_phys_bits is dealt with (and to cease assuming little-endian by default). The same probably applied to softfloat, although I do not know whether defaulting to '$target_softfloat = "yes"' and then setting that to "no" for the targets where it is not wanted would be preferred. FWIW, the list of architectures that currently don't define CONFIG_SOFTFLOAT seems to be: i386 x86_64 alpha sh4 sh4eb Also, I'm not sure whether setting target_has_{kqemu,kvm,xen} variables where target_phys_bits is set would also be slightly cleaner... although perhaps those particular architecture lists are unlikely to grow much... I'm not sure how much of this you're interested in fixing, but I'll be happy to post patches for any changes that you don't see as essential. Cheers, -- Stuart Brady