qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bique Alexandre <alexandre.bique@citrix.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH 2/5] ATAPI pass through v2: adds few comments
Date: Wed, 1 Jul 2009 19:32:01 +0100	[thread overview]
Message-ID: <200907011932.01263.alexandre.bique@citrix.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 84 bytes --]

This patch adds few comments to some CD-ROM emulated commands.

-- 
Alexandre Bique

[-- Attachment #2: atapi-comments --]
[-- Type: text/x-patch, Size: 1500 bytes --]

diff --git a/hw/ide.c b/hw/ide.c
index 1e56786..063f08d 100644
--- a/hw/ide.c
+++ b/hw/ide.c
@@ -1664,9 +1664,9 @@ static void ide_atapi_cmd(IDEState *s)
             switch(action) {
             case 0: /* current values */
                 switch(code) {
-                case 0x01: /* error recovery */
+                case 0x01: /* read write error recovery parameters */
                     cpu_to_ube16(&buf[0], 16 + 6);
-                    buf[2] = 0x70;
+                    buf[2] = 0x70; /* Obselete: medium type code */
                     buf[3] = 0;
                     buf[4] = 0;
                     buf[5] = 0;
@@ -1683,17 +1683,17 @@ static void ide_atapi_cmd(IDEState *s)
                     buf[15] = 0x00;
                     ide_atapi_cmd_reply(s, 16, max_len);
                     break;
-                case 0x2a:
+                case 0x2a: /* CD/DVD capabilities & mechanical status */
                     cpu_to_ube16(&buf[0], 28 + 6);
-                    buf[2] = 0x70;
+                    buf[2] = 0x70; /* Obselete: medium type code */
                     buf[3] = 0;
                     buf[4] = 0;
                     buf[5] = 0;
                     buf[6] = 0;
                     buf[7] = 0;
 
-                    buf[8] = 0x2a;
-                    buf[9] = 0x12;
+                    buf[8] = 0x2a; /* page code */
+                    buf[9] = 0x12; /* page lenght */
                     buf[10] = 0x00;
                     buf[11] = 0x00;
 

             reply	other threads:[~2009-07-01 18:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 18:32 Bique Alexandre [this message]
     [not found] ` <m33a9g8cm7.fsf@neno.mitica>
2009-07-02 10:38   ` [Qemu-devel] Re: [PATCH 2/5] ATAPI pass through v2: adds few comments Bique Alexandre
2009-07-05  9:06     ` Stuart Brady
2009-07-05  8:08 ` [Qemu-devel] " Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907011932.01263.alexandre.bique@citrix.com \
    --to=alexandre.bique@citrix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).