qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Paul Brook <paul@codesourcery.com>
Cc: Riku Voipio <riku.voipio@iki.fi>,
	qemu-devel@nongnu.org, Arnaud Patard <arnaud.patard@rtp-net.org>
Subject: Re: [Qemu-devel] [PATCH 3/5] linux-user: do not avoid dumping of qemu itself
Date: Thu, 2 Jul 2009 03:19:21 +0100	[thread overview]
Message-ID: <20090702021921.GB18372@shareable.org> (raw)
In-Reply-To: <200907020032.00212.paul@codesourcery.com>

Paul Brook wrote:
> > >> It sounds like WCOREDUMP is one of those things that just isn't going to
> > >> work. i.e. we have to just accept the limitation and xfail the test.
> > >
> > > If this how people feel, I'll be glad to drop this patch.
> >
> > well, as I said either we fix it or we accept that the emulation is not
> > perfect and judge that this feature is worth it.
> 
> It's not quite that simple.
> 
> I think this is a case of someone blindly "fixing" a testsuite without any 
> consideration of what is actually being implemented.
> 
> IMO a host core dump is for most purposes useless[1], and dumping
> guest state to a different location is a bug.  Given the choice
> between dumping guest core in the "normal" location and setting the
> WCOREDUMP flag, the former seems much more useful.

It's a really minor corner case, but I wonder if it's worth adding a
prctl() option or some bit in the info passed to sigqueue(), to the
Linux kernel to set the WCOREDUMP flag on exit.  Meaning "app has
coredumped itself".

> [1] A host core dump may be useful for debugging qemu itself, but that's a 
> fairly specialized corner case, and not necessarily something we want to be 
> exposing to users.

It would make sense to set RLIMIT_CORE to zero very early in
qemu-user, and then someone debugging qemu-user can easily change
RLIMIT_CORE from gdb while it is running.

-- Jamie

  reply	other threads:[~2009-07-02  2:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 14:15 [Qemu-devel] [PATCH 0/5] Fixes for linux-user riku.voipio
2009-06-30 14:15 ` [Qemu-devel] [PATCH 1/5] linux-user: increment MAX_ARG_PAGES riku.voipio
2009-06-30 14:15 ` [Qemu-devel] [PATCH 2/5] linux-user: check some parameters for some socket syscalls riku.voipio
2009-06-30 14:15 ` [Qemu-devel] [PATCH 3/5] linux-user: do not avoid dumping of qemu itself riku.voipio
2009-06-30 14:52   ` Paul Brook
2009-06-30 17:01     ` Riku Voipio
2009-07-01 20:34       ` Arnaud Patard
2009-07-01 23:31         ` Paul Brook
2009-07-02  2:19           ` Jamie Lokier [this message]
2009-07-02 13:19             ` Paul Brook
2009-07-02 20:01               ` Riku Voipio
2009-07-03  2:25                 ` Jamie Lokier
2009-07-03  2:20               ` Jamie Lokier
2009-06-30 14:15 ` [Qemu-devel] [PATCH 4/5] linux-user/syscall.c: remove warning: ‘array’ may be used uninitialized in this function riku.voipio
2009-06-30 14:15 ` [Qemu-devel] [PATCH 5/5] configure: remove bogus linux-user check riku.voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090702021921.GB18372@shareable.org \
    --to=jamie@shareable.org \
    --cc=arnaud.patard@rtp-net.org \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).