From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MMHyX-00020w-7U
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 04:49:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MMHyR-0001zp-KD
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 04:48:59 -0400
Received: from [199.232.76.173] (port=42874 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MMHyR-0001zm-Eu
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 04:48:55 -0400
Received: from verein.lst.de ([213.95.11.210]:55096)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MMHyQ-0006N5-TU
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 04:48:55 -0400
Date: Thu, 2 Jul 2009 10:48:48 +0200
From: Christoph Hellwig <hch@lst.de>
Message-ID: <20090702084848.GA32699@lst.de>
References: <a8d88129bff47f8006a614998b63b302@gmail.com>
	<20090626175538.GA4077@lst.de>
	<3b18e1127cac98f7cacb6cca22fed96e@gmail.com>
	<20090701135404.GB16868@lst.de>
	<45f1eeaa1ea123585c41d07c49584ead@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <45f1eeaa1ea123585c41d07c49584ead@gmail.com>
Subject: [Qemu-devel] Re: [PATCH] Substitute O_DSYNC with O_SYNC or O_FSYNC
	when needed.
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: G 3 <programmingkidx@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Wed, Jul 01, 2009 at 01:28:32PM -0400, G 3 wrote:
> This patch should be what you want.
> 
> commit b32354139556d1a807d04aa54ed82610e0f4507a
> Author: John Arbuckle <programmingkidx@gmail.com>
> Date:   Wed Jul 1 13:24:37 2009 -0400
> 
>     Substitute O_DSYNC with O_SYNC or O_FSYNC when needed.
> 
>     Signed-off-by: John Arbuckle <programmingkidx@gmail.com>

Thanks, looks good to me,


Reviewed-by: Christoph Hellwig <hch@lst.de>

> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index 8b1e67c..17338ee 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -81,7 +81,11 @@
> 
>  /* OS X does not have O_DSYNC */
>  #ifndef O_DSYNC
> +#ifdef O_SYNC
>  #define O_DSYNC O_SYNC
> +#elif defined(O_FSYNC)
> +#define O_DSYNC O_FSYNC
> +#endif
>  #endif
---end quoted text---