From: Jamie Lokier <jamie@shareable.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Robert Reif <reif@earthlink.net>
Subject: Re: [Qemu-devel] [PATCH] fix hw/scsi-disk.c compile errors
Date: Thu, 2 Jul 2009 09:53:31 +0100 [thread overview]
Message-ID: <20090702085331.GA1497@shareable.org> (raw)
In-Reply-To: <4A4C57DA.8010202@redhat.com>
Gerd Hoffmann wrote:
> On 07/02/09 01:40, Robert Reif wrote:
> >This patch fixes 2 compile errors when debugging is enabled.
> >
> >CC scsi-disk.o
> >cc1: warnings being treated as errors
> >/home/reif/qemu/hw/scsi-disk.c: In function ‘scsi_send_command’:
> >/home/reif/qemu/hw/scsi-disk.c:797: error: format ‘%d’ expects type
> >‘int’, but argument 2 has type ‘uint64_t’
>
> > - DPRINTF("Synchronise cache (sector %d, count %d)\n", lba, len);
> > + DPRINTF("Synchronise cache (sector %lld, count %d)\n", lba,
> len);
>
> Doesn't work. Well, it works on 32bit, but will fail on 64bit. Use the
> macros provided by inttypes.h instead, i.e.
>
> "... (sector %" PRId64 ", count ...", lba
Given the error, PRIu64 looks better.
-- Jamie
next prev parent reply other threads:[~2009-07-02 8:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 23:40 [Qemu-devel] [PATCH] fix hw/scsi-disk.c compile errors Robert Reif
2009-07-02 6:46 ` Gerd Hoffmann
2009-07-02 8:53 ` Jamie Lokier [this message]
2009-07-02 11:06 ` Robert Reif
2009-07-09 19:16 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090702085331.GA1497@shareable.org \
--to=jamie@shareable.org \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=reif@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).