From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MMQkl-000723-Ed
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 14:11:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MMQkf-0006zH-Ux
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 14:11:22 -0400
Received: from [199.232.76.173] (port=35811 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MMQkf-0006zE-PC
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 14:11:17 -0400
Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]:60462)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1MMQkf-00028K-BS
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 14:11:17 -0400
Received: from aamtaout04-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout02-winn.ispmail.ntl.com
	(InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id
	<20090702181116.ZRTU6611.mtaout02-winn.ispmail.ntl.com@aamtaout04-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Thu, 2 Jul 2009 19:11:16 +0100
Received: from miranda.arrow ([213.107.24.213])
	by aamtaout04-winn.ispmail.ntl.com
	(InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id
	<20090702181116.HFYZ22934.aamtaout04-winn.ispmail.ntl.com@miranda.arrow>
	for <qemu-devel@nongnu.org>; Thu, 2 Jul 2009 19:11:16 +0100
Received: from sdb by miranda.arrow with local (Exim 4.63)
	(envelope-from <sdbrady@ntlworld.com>) id 1MMQkb-0004ze-KS
	for qemu-devel@nongnu.org; Thu, 02 Jul 2009 19:11:13 +0100
Date: Thu, 2 Jul 2009 19:11:13 +0100
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value
	instead of int.
Message-ID: <20090702181113.GA19151@miranda.arrow>
References: <1246530731-14597-1-git-send-email-yamahata@valinux.co.jp>
	<1246530731-14597-7-git-send-email-yamahata@valinux.co.jp>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1246530731-14597-7-git-send-email-yamahata@valinux.co.jp>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Thu, Jul 02, 2009 at 07:32:11PM +0900, Isaku Yamahata wrote:
> -void cpu_outb(CPUState *env, int addr, int val)
> +void cpu_outb(CPUState *env, uint32_t addr, uint32_t val)

uint8_t for 'b' and uint16_t for 'w' might be slightly better, in that
it would allow compiler warnings regarding truncations to be generated.

> -    LOG_UNUSED_IOPORT("unused inb: port=0x%04x\n", address);
> +    LOG_UNUSED_IOPORT(stderr, "unused inb: port=0x%04"PRIx32"\n", address);

These don't look intentional...
-- 
Stuart Brady