From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MMR3Q-0002LF-K4 for qemu-devel@nongnu.org; Thu, 02 Jul 2009 14:30:40 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MMR3L-0002Ke-WB for qemu-devel@nongnu.org; Thu, 02 Jul 2009 14:30:40 -0400 Received: from [199.232.76.173] (port=37576 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MMR3L-0002Kb-Tw for qemu-devel@nongnu.org; Thu, 02 Jul 2009 14:30:35 -0400 Received: from mtaout02-winn.ispmail.ntl.com ([81.103.221.48]:12576) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MMR3L-0005YQ-FP for qemu-devel@nongnu.org; Thu, 02 Jul 2009 14:30:35 -0400 Received: from aamtaout01-winn.ispmail.ntl.com ([81.103.221.35]) by mtaout02-winn.ispmail.ntl.com (InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id <20090702183034.JAS6611.mtaout02-winn.ispmail.ntl.com@aamtaout01-winn.ispmail.ntl.com> for ; Thu, 2 Jul 2009 19:30:34 +0100 Received: from miranda.arrow ([213.107.24.213]) by aamtaout01-winn.ispmail.ntl.com (InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id <20090702183034.GWUT13254.aamtaout01-winn.ispmail.ntl.com@miranda.arrow> for ; Thu, 2 Jul 2009 19:30:34 +0100 Received: from sdb by miranda.arrow with local (Exim 4.63) (envelope-from ) id 1MMR3H-00050v-UP for qemu-devel@nongnu.org; Thu, 02 Jul 2009 19:30:32 +0100 Date: Thu, 2 Jul 2009 19:30:31 +0100 From: Stuart Brady Subject: Re: [Qemu-devel] [PATCH 6/6] use uint32_t for ioport port and value instead of int. Message-ID: <20090702183031.GA19264@miranda.arrow> References: <1246530731-14597-1-git-send-email-yamahata@valinux.co.jp> <1246530731-14597-7-git-send-email-yamahata@valinux.co.jp> <20090702181113.GA19151@miranda.arrow> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090702181113.GA19151@miranda.arrow> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org On Thu, Jul 02, 2009 at 07:11:13PM +0100, Stuart Brady wrote: > On Thu, Jul 02, 2009 at 07:32:11PM +0900, Isaku Yamahata wrote: > > - LOG_UNUSED_IOPORT("unused inb: port=0x%04x\n", address); > > + LOG_UNUSED_IOPORT(stderr, "unused inb: port=0x%04"PRIx32"\n", address); > > These don't look intentional... To clarify, I was referring to the 'stderr' part, and missed the 'PRIx32'. Cheers, -- Stuart Brady