qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Riku Voipio <riku.voipio@iki.fi>
Cc: Paul Brook <paul@codesourcery.com>,
	Arnaud Patard <arnaud.patard@rtp-net.org>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/5] linux-user: do not avoid dumping of qemu itself
Date: Fri, 3 Jul 2009 03:25:18 +0100	[thread overview]
Message-ID: <20090703022518.GC938@shareable.org> (raw)
In-Reply-To: <20090702200102.GA7219@kos.to>

Riku Voipio wrote:
> On Thu, Jul 02, 2009 at 02:19:29PM +0100, Paul Brook wrote:
> > > > [1] A host core dump may be useful for debugging qemu itself, but that's
> > > > a fairly specialized corner case, and not necessarily something we want
> > > > to be exposing to users.
> 
> > > It would make sense to set RLIMIT_CORE to zero very early in
> > > qemu-user, and then someone debugging qemu-user can easily change
> > > RLIMIT_CORE from gdb while it is running.
> 
> > Sounds reasonable, as long as you're careful to avoid breaking guest 
> > applications that call {get,set}rlimit(RLIMIT_CORE).
> 
> The host process coredump is still not very useful, as kernel creates it
> only after we come out of our signal handler?

The kernel will create the host coredump when the host process dies.
That is, when it receives a fatal unhandled signal.

Generally I'd expect we shouldn't create a coredump if QEMU sends
itself a signal deliberately, just to indicate that the process
terminates with a guest signal.  But it would be a bit more useful
when QEMU receives a signal due to a bug in QEMU (when debugging sets
RLIMIT_CORE).  There might not be a clean way to distinguish the two
conditions.

> Also, I don't think there
> is any real world application that would behave unexpectedly if one
> of it's child processes dies without the coredump bit being set...

I agree, I've never heard of any.  Quite a few will behave
differently, in a minor way, such as the different termination message
shown by shells.

-- Jamie

  reply	other threads:[~2009-07-03  2:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-30 14:15 [Qemu-devel] [PATCH 0/5] Fixes for linux-user riku.voipio
2009-06-30 14:15 ` [Qemu-devel] [PATCH 1/5] linux-user: increment MAX_ARG_PAGES riku.voipio
2009-06-30 14:15 ` [Qemu-devel] [PATCH 2/5] linux-user: check some parameters for some socket syscalls riku.voipio
2009-06-30 14:15 ` [Qemu-devel] [PATCH 3/5] linux-user: do not avoid dumping of qemu itself riku.voipio
2009-06-30 14:52   ` Paul Brook
2009-06-30 17:01     ` Riku Voipio
2009-07-01 20:34       ` Arnaud Patard
2009-07-01 23:31         ` Paul Brook
2009-07-02  2:19           ` Jamie Lokier
2009-07-02 13:19             ` Paul Brook
2009-07-02 20:01               ` Riku Voipio
2009-07-03  2:25                 ` Jamie Lokier [this message]
2009-07-03  2:20               ` Jamie Lokier
2009-06-30 14:15 ` [Qemu-devel] [PATCH 4/5] linux-user/syscall.c: remove warning: ‘array’ may be used uninitialized in this function riku.voipio
2009-06-30 14:15 ` [Qemu-devel] [PATCH 5/5] configure: remove bogus linux-user check riku.voipio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090703022518.GC938@shareable.org \
    --to=jamie@shareable.org \
    --cc=arnaud.patard@rtp-net.org \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).