From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>, Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v2] Use ctz64 in favor of ffsll
Date: Fri, 3 Jul 2009 10:35:18 +0100 [thread overview]
Message-ID: <200907031035.20520.paul@codesourcery.com> (raw)
In-Reply-To: <4A4C5DA9.8020909@web.de>
On Thursday 02 July 2009, Jan Kiszka wrote:
> Not all host platforms support ffsll.
>- pending_irq = i * 64 + bit - 1;
>+ bit = ctz64(env->interrupt_bitmap[i]);
>+ pending_irq = i * 64 + bit;
Are we sure there is only ever one bit set in interrupt_bitmap?
If not does it mater that we're processing them in reverse order?
Paul
next prev parent reply other threads:[~2009-07-03 9:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 20:22 [Qemu-devel] [PATCH] Use ffs in favor of ffsll Jan Kiszka
2009-07-01 20:27 ` [Qemu-devel] " Blue Swirl
2009-07-01 20:35 ` Jan Kiszka
2009-07-01 20:55 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
2009-07-01 20:58 ` Nathan Froyd
2009-07-01 22:24 ` [Qemu-devel] " Jan Kiszka
2009-07-01 23:02 ` [Qemu-devel] " Stuart Brady
2009-07-02 7:04 ` [Qemu-devel] [PATCH] Use ctz64 " Jan Kiszka
2009-07-02 7:11 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
2009-07-03 9:35 ` Paul Brook [this message]
2009-07-04 7:16 ` Jan Kiszka
2009-07-02 8:39 ` [Qemu-devel] Re: [PATCH] Use ffs " Christoph Egger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907031035.20520.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).