From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MMfB6-0003dt-14
	for qemu-devel@nongnu.org; Fri, 03 Jul 2009 05:35:32 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MMfB1-0003c1-1T
	for qemu-devel@nongnu.org; Fri, 03 Jul 2009 05:35:31 -0400
Received: from [199.232.76.173] (port=47523 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MMfB0-0003by-Qp
	for qemu-devel@nongnu.org; Fri, 03 Jul 2009 05:35:26 -0400
Received: from mx20.gnu.org ([199.232.41.8]:42903)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1MMfB0-00014T-Hc
	for qemu-devel@nongnu.org; Fri, 03 Jul 2009 05:35:26 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1MMfAy-0003H6-IB
	for qemu-devel@nongnu.org; Fri, 03 Jul 2009 05:35:24 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH v2] Use ctz64 in favor of ffsll
Date: Fri, 3 Jul 2009 10:35:18 +0100
References: <4A4BC57E.504@web.de> <4A4C5C0E.2050502@web.de>
	<4A4C5DA9.8020909@web.de>
In-Reply-To: <4A4C5DA9.8020909@web.de>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200907031035.20520.paul@codesourcery.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>, Anthony Liguori <aliguori@us.ibm.com>

On Thursday 02 July 2009, Jan Kiszka wrote:
> Not all host platforms support ffsll.

>-            pending_irq = i * 64 + bit - 1;
>+            bit = ctz64(env->interrupt_bitmap[i]);
>+            pending_irq = i * 64 + bit;

Are we sure there is only ever one bit set in interrupt_bitmap?
If not does it mater that we're processing them in reverse order?

Paul