qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Bique Alexandre <alexandre.bique@citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 2/5] ATAPI pass through v2: adds few comments
Date: Sun, 5 Jul 2009 10:08:39 +0200	[thread overview]
Message-ID: <20090705080839.GA31774@lst.de> (raw)
In-Reply-To: <200907011932.01263.alexandre.bique@citrix.com>

On Wed, Jul 01, 2009 at 07:32:01PM +0100, Bique Alexandre wrote:
> This patch adds few comments to some CD-ROM emulated commands.

Looks good to be, but long term we'd be better off having headers with
symbolic names for all the constants from the standards..

      parent reply	other threads:[~2009-07-05  8:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 18:32 [Qemu-devel] [PATCH 2/5] ATAPI pass through v2: adds few comments Bique Alexandre
     [not found] ` <m33a9g8cm7.fsf@neno.mitica>
2009-07-02 10:38   ` [Qemu-devel] " Bique Alexandre
2009-07-05  9:06     ` Stuart Brady
2009-07-05  8:08 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090705080839.GA31774@lst.de \
    --to=hch@lst.de \
    --cc=alexandre.bique@citrix.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).