From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNMmH-0000TN-HZ
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:08:49 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNMmC-0000SN-FK
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:08:48 -0400
Received: from [199.232.76.173] (port=41705 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNMmC-0000SI-Bt
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:08:44 -0400
Received: from verein.lst.de ([213.95.11.210]:43510)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MNMmB-0001P5-Pv
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:08:44 -0400
Date: Sun, 5 Jul 2009 10:08:39 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 2/5] ATAPI pass through v2: adds few comments
Message-ID: <20090705080839.GA31774@lst.de>
References: <200907011932.01263.alexandre.bique@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200907011932.01263.alexandre.bique@citrix.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bique Alexandre <alexandre.bique@citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Wed, Jul 01, 2009 at 07:32:01PM +0100, Bique Alexandre wrote:
> This patch adds few comments to some CD-ROM emulated commands.

Looks good to be, but long term we'd be better off having headers with
symbolic names for all the constants from the standards..