From: Christoph Hellwig <hch@lst.de>
To: Bique Alexandre <alexandre.bique@citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 4/5] ATAPI pass through v2: bring the new ATAPI pass throug feature
Date: Sun, 5 Jul 2009 10:15:33 +0200 [thread overview]
Message-ID: <20090705081533.GA32124@lst.de> (raw)
In-Reply-To: <200907011932.09210.alexandre.bique@citrix.com>
On Wed, Jul 01, 2009 at 07:32:09PM +0100, Bique Alexandre wrote:
> This patch brings the new ATAPI pass through feature.
I really don't understand the need for the BDRV_TYPE_CDROM_PT block
device type. The use of BDRV_TYPE_* is mostly a hint for ide/scsi
what kind of device where dealing with, and a passthrough CDROM should
be different from a real one. I think we should just make any drive
that points to a hardware CDROM device use the passthrough code, similar
to how you'll get a hardware passthrough SCSI CDROM if you point the
-drive option to a /dev/sr* device for a host CDROM.
next prev parent reply other threads:[~2009-07-05 8:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 18:32 [Qemu-devel] [PATCH 4/5] ATAPI pass through v2: bring the new ATAPI pass throug feature Bique Alexandre
2009-07-05 8:15 ` Christoph Hellwig [this message]
2009-07-06 11:23 ` Bique Alexandre
[not found] ` <200907091548.34224.alexandre.bique@citrix.com>
2009-07-29 10:54 ` Bique Alexandre
2009-07-07 12:45 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090705081533.GA32124@lst.de \
--to=hch@lst.de \
--cc=alexandre.bique@citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).