From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNMsv-0002zM-7q for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:15:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNMsq-0002yk-TX for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:15:40 -0400 Received: from [199.232.76.173] (port=39729 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNMsq-0002yh-MD for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:15:36 -0400 Received: from verein.lst.de ([213.95.11.210]:43634) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MNMsq-0002cX-6m for qemu-devel@nongnu.org; Sun, 05 Jul 2009 04:15:36 -0400 Date: Sun, 5 Jul 2009 10:15:33 +0200 From: Christoph Hellwig Subject: Re: [Qemu-devel] [PATCH 4/5] ATAPI pass through v2: bring the new ATAPI pass throug feature Message-ID: <20090705081533.GA32124@lst.de> References: <200907011932.09210.alexandre.bique@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200907011932.09210.alexandre.bique@citrix.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bique Alexandre Cc: "qemu-devel@nongnu.org" On Wed, Jul 01, 2009 at 07:32:09PM +0100, Bique Alexandre wrote: > This patch brings the new ATAPI pass through feature. I really don't understand the need for the BDRV_TYPE_CDROM_PT block device type. The use of BDRV_TYPE_* is mostly a hint for ide/scsi what kind of device where dealing with, and a passthrough CDROM should be different from a real one. I think we should just make any drive that points to a hardware CDROM device use the passthrough code, similar to how you'll get a hardware passthrough SCSI CDROM if you point the -drive option to a /dev/sr* device for a host CDROM.