From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNPDq-0003Xb-9b
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 06:45:26 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNPDl-0003XN-NK
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 06:45:25 -0400
Received: from [199.232.76.173] (port=41333 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNPDl-0003XK-FN
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 06:45:21 -0400
Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47]:31599)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1MNPDk-0007b5-Tz
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 06:45:21 -0400
Received: from aamtaout03-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout01-winn.ispmail.ntl.com
	(InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id
	<20090705104519.OLVO6742.mtaout01-winn.ispmail.ntl.com@aamtaout03-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Sun, 5 Jul 2009 11:45:19 +0100
Received: from miranda.arrow ([213.107.24.213])
	by aamtaout03-winn.ispmail.ntl.com
	(InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id
	<20090705104519.CGVJ2093.aamtaout03-winn.ispmail.ntl.com@miranda.arrow>
	for <qemu-devel@nongnu.org>; Sun, 5 Jul 2009 11:45:19 +0100
Received: from sdb by miranda.arrow with local (Exim 4.63)
	(envelope-from <sdbrady@ntlworld.com>) id 1MNPDh-0000PO-6l
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 11:45:17 +0100
Date: Sun, 5 Jul 2009 11:45:17 +0100
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [PATCHv3 1/3] qemu/msi: fix segfault in msix_save
Message-ID: <20090705104516.GA1555@miranda.arrow>
References: <cover.1246782566.git.mst@redhat.com>
	<20090705102423.GA3833@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090705102423.GA3833@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Sun, Jul 05, 2009 at 01:24:24PM +0300, Michael S. Tsirkin wrote:
> +    if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
> +        return;

Same bug as fixed by 98846d7 ('Fix Sparse warning').

Should be:

    if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) {
        return;
    }

Cheers,
-- 
Stuart Brady