From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, avi@redhat.com, kvm@vger.kernel.org,
aliguori@us.ibm.com, kwolf@redhat.com, glommer@redhat.com,
blauwirbel@gmail.com
Subject: [Qemu-devel] [PATCHv4 4/5] qemu/msi: missing braces
Date: Sun, 5 Jul 2009 14:40:57 +0300 [thread overview]
Message-ID: <20090705114057.GE4798@redhat.com> (raw)
In-Reply-To: <cover.1246793893.git.mst@redhat.com>
MSIX present bit is tested incorrectly, and only happens to work because
the bit we are testing is 0x1. Add braces to fix this.
Reported-by: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/msix.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/msix.c b/hw/msix.c
index 33549f5..db72cc3 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -298,7 +298,7 @@ void msix_load(PCIDevice *dev, QEMUFile *f)
{
unsigned n = dev->msix_entries_nr;
- if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
+ if (!(dev->cap_present & QEMU_PCI_CAP_MSIX))
return;
msix_free_irq_entries(dev);
--
1.6.2.2
next prev parent reply other threads:[~2009-07-05 11:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1246793893.git.mst@redhat.com>
2009-07-05 11:40 ` [Qemu-devel] [PATCHv4 1/5] qemu/msi: fix segfault in msix_save Michael S. Tsirkin
2009-07-05 11:40 ` [Qemu-devel] [PATCHv4 2/5] qemu/virtio: remove control vector save Michael S. Tsirkin
2009-07-05 11:40 ` [Qemu-devel] [PATCHv4 3/5] qemu/msi: clean used vectors state on load Michael S. Tsirkin
2009-07-05 11:40 ` Michael S. Tsirkin [this message]
2009-07-05 11:48 ` [Qemu-devel] Re: [PATCHv4 4/5] qemu/msi: missing braces Blue Swirl
2009-07-05 11:56 ` Michael S. Tsirkin
2009-07-05 12:03 ` Blue Swirl
2009-07-05 12:07 ` Avi Kivity
2009-07-05 13:18 ` Michael S. Tsirkin
2009-07-05 11:41 ` [Qemu-devel] [PATCHv4 5/5] qemu/virtio: mark msi vectors used on load Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090705114057.GE4798@redhat.com \
--to=mst@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=glommer@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).