From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNQ6J-0007zS-CN for qemu-devel@nongnu.org; Sun, 05 Jul 2009 07:41:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNQ6E-0007xg-Pv for qemu-devel@nongnu.org; Sun, 05 Jul 2009 07:41:42 -0400 Received: from [199.232.76.173] (port=50325 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNQ6E-0007xY-JC for qemu-devel@nongnu.org; Sun, 05 Jul 2009 07:41:38 -0400 Received: from mx2.redhat.com ([66.187.237.31]:43984) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MNQ6E-00078H-67 for qemu-devel@nongnu.org; Sun, 05 Jul 2009 07:41:38 -0400 Date: Sun, 5 Jul 2009 14:40:57 +0300 From: "Michael S. Tsirkin" Message-ID: <20090705114057.GE4798@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] [PATCHv4 4/5] qemu/msi: missing braces List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, avi@redhat.com, kvm@vger.kernel.org, aliguori@us.ibm.com, kwolf@redhat.com, glommer@redhat.com, blauwirbel@gmail.com MSIX present bit is tested incorrectly, and only happens to work because the bit we are testing is 0x1. Add braces to fix this. Reported-by: Blue Swirl Signed-off-by: Michael S. Tsirkin --- hw/msix.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 33549f5..db72cc3 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -298,7 +298,7 @@ void msix_load(PCIDevice *dev, QEMUFile *f) { unsigned n = dev->msix_entries_nr; - if (!dev->cap_present & QEMU_PCI_CAP_MSIX) + if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) return; msix_free_irq_entries(dev); -- 1.6.2.2