From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNQKu-00058q-Qn
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 07:56:48 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNQKq-000565-3T
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 07:56:48 -0400
Received: from [199.232.76.173] (port=54436 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNQKp-00055r-W9
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 07:56:44 -0400
Received: from mx2.redhat.com ([66.187.237.31]:48704)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MNQKp-0000jP-GK
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 07:56:43 -0400
Date: Sun, 5 Jul 2009 14:56:01 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20090705115601.GA4826@redhat.com>
References: <cover.1246793893.git.mst@redhat.com>
	<20090705114057.GE4798@redhat.com>
	<f43fc5580907050448w6a254762y51d57f192978da3b@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f43fc5580907050448w6a254762y51d57f192978da3b@mail.gmail.com>
Subject: [Qemu-devel] Re: [PATCHv4 4/5] qemu/msi: missing braces
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org, glommer@redhat.com, qemu-devel@nongnu.org, avi@redhat.com

On Sun, Jul 05, 2009 at 02:48:12PM +0300, Blue Swirl wrote:
> On 7/5/09, Michael S. Tsirkin <mst@redhat.com> wrote:
> > MSIX present bit is tested incorrectly, and only happens to work because
> >  the bit we are testing is 0x1.  Add braces to fix this.
> >
> >  Reported-by: Blue Swirl <blauwirbel@gmail.com>
> >  Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >  ---
> >   hw/msix.c |    2 +-
> >   1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >  diff --git a/hw/msix.c b/hw/msix.c
> >  index 33549f5..db72cc3 100644
> >  --- a/hw/msix.c
> >  +++ b/hw/msix.c
> >  @@ -298,7 +298,7 @@ void msix_load(PCIDevice *dev, QEMUFile *f)
> >   {
> >      unsigned n = dev->msix_entries_nr;
> >
> >  -    if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
> >  +    if (!(dev->cap_present & QEMU_PCI_CAP_MSIX))
> 
> With the braces comment I meant that while working on the code, you
> should update it to match CODING_STYLE:
> if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) {
>     return;
> }

Yea ... it's probably better to do this all over the file, not piecewise,
though. No?

-- 
MST