qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, avi@redhat.com, kvm@vger.kernel.org,
	aliguori@us.ibm.com, kwolf@redhat.com, glommer@redhat.com,
	blauwirbel@gmail.com
Subject: [Qemu-devel] [PATCHv5 4/5] qemu/msi: missing braces
Date: Sun, 5 Jul 2009 15:58:52 +0300	[thread overview]
Message-ID: <20090705125852.GE5417@redhat.com> (raw)
In-Reply-To: <cover.1246798625.git.mst@redhat.com>

MSIX present bit is tested incorrectly, and only happens to work because
the bit we are testing is 0x1.  Add braces to fix this.

Reported-by: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/msix.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/msix.c b/hw/msix.c
index 80038d3..4224d8f 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -298,9 +298,9 @@ void msix_load(PCIDevice *dev, QEMUFile *f)
 {
     unsigned n = dev->msix_entries_nr;
 
-    if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
+    if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) {
         return;
-
+    }
     msix_free_irq_entries(dev);
     qemu_get_buffer(f, dev->msix_table_page, n * MSIX_ENTRY_SIZE);
     qemu_get_buffer(f, dev->msix_table_page + MSIX_PAGE_PENDING, (n + 7) / 8);
-- 
1.6.2.2

  parent reply	other threads:[~2009-07-05 13:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1246798625.git.mst@redhat.com>
2009-07-05 12:58 ` [Qemu-devel] [PATCHv5 1/5] qemu/msi: fix segfault in msix_save Michael S. Tsirkin
2009-07-09 19:08   ` Luiz Capitulino
2009-07-09 19:12     ` Anthony Liguori
2009-07-05 12:58 ` [Qemu-devel] [PATCHv5 2/5] qemu/virtio: remove control vector save Michael S. Tsirkin
2009-07-05 12:58 ` [Qemu-devel] [PATCHv5 3/5] qemu/msi: clean used vectors state on load Michael S. Tsirkin
2009-07-05 12:58 ` Michael S. Tsirkin [this message]
2009-07-05 13:02 ` [Qemu-devel] [PATCHv5 5/5] qemu/virtio: mark msi vectors used " Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090705125852.GE5417@redhat.com \
    --to=mst@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=glommer@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).