From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNRKM-0006au-Hx for qemu-devel@nongnu.org; Sun, 05 Jul 2009 09:00:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNRKH-0006aT-Te for qemu-devel@nongnu.org; Sun, 05 Jul 2009 09:00:17 -0400 Received: from [199.232.76.173] (port=55063 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNRKH-0006aQ-PG for qemu-devel@nongnu.org; Sun, 05 Jul 2009 09:00:13 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37566) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MNRKH-00054I-8s for qemu-devel@nongnu.org; Sun, 05 Jul 2009 09:00:13 -0400 Date: Sun, 5 Jul 2009 15:58:52 +0300 From: "Michael S. Tsirkin" Message-ID: <20090705125852.GE5417@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: [Qemu-devel] [PATCHv5 4/5] qemu/msi: missing braces List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, avi@redhat.com, kvm@vger.kernel.org, aliguori@us.ibm.com, kwolf@redhat.com, glommer@redhat.com, blauwirbel@gmail.com MSIX present bit is tested incorrectly, and only happens to work because the bit we are testing is 0x1. Add braces to fix this. Reported-by: Blue Swirl Signed-off-by: Michael S. Tsirkin --- hw/msix.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/msix.c b/hw/msix.c index 80038d3..4224d8f 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -298,9 +298,9 @@ void msix_load(PCIDevice *dev, QEMUFile *f) { unsigned n = dev->msix_entries_nr; - if (!dev->cap_present & QEMU_PCI_CAP_MSIX) + if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) { return; - + } msix_free_irq_entries(dev); qemu_get_buffer(f, dev->msix_table_page, n * MSIX_ENTRY_SIZE); qemu_get_buffer(f, dev->msix_table_page + MSIX_PAGE_PENDING, (n + 7) / 8); -- 1.6.2.2