From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNRd6-0006bE-Pv for qemu-devel@nongnu.org; Sun, 05 Jul 2009 09:19:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNRd0-0006Mt-FZ for qemu-devel@nongnu.org; Sun, 05 Jul 2009 09:19:38 -0400 Received: from [199.232.76.173] (port=49192 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNRcz-0006MW-RY for qemu-devel@nongnu.org; Sun, 05 Jul 2009 09:19:33 -0400 Received: from mx2.redhat.com ([66.187.237.31]:58960) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MNRcz-0007mw-EZ for qemu-devel@nongnu.org; Sun, 05 Jul 2009 09:19:33 -0400 Date: Sun, 5 Jul 2009 16:18:50 +0300 From: "Michael S. Tsirkin" Message-ID: <20090705131850.GA5513@redhat.com> References: <20090705114057.GE4798@redhat.com> <20090705115601.GA4826@redhat.com> <4A50976A.8040901@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A50976A.8040901@redhat.com> Subject: [Qemu-devel] Re: [PATCHv4 4/5] qemu/msi: missing braces List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: kwolf@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org, glommer@redhat.com, qemu-devel@nongnu.org, Blue Swirl On Sun, Jul 05, 2009 at 03:07:06PM +0300, Avi Kivity wrote: > On 07/05/2009 02:56 PM, Michael S. Tsirkin wrote: >>> With the braces comment I meant that while working on the code, you >>> should update it to match CODING_STYLE: >>> if (!(dev->cap_present& QEMU_PCI_CAP_MSIX)) { >>> return; >>> } >>> >> >> Yea ... it's probably better to do this all over the file, not piecewise, >> though. No? >> > > No, that just causes churn (and merge conflicts for me). Better to only > fix if you have a patch that modifies the same place. OK, I redid these patches with {}. Even though the kernel style is better! ;) -- MST