From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNXhE-0007oW-6T
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 15:48:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNXh9-0007n3-Dy
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 15:48:19 -0400
Received: from [199.232.76.173] (port=37755 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNXh9-0007n0-7l
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 15:48:15 -0400
Received: from mx2.redhat.com ([66.187.237.31]:34329)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <mst@redhat.com>) id 1MNXh8-0007xx-Lb
	for qemu-devel@nongnu.org; Sun, 05 Jul 2009 15:48:14 -0400
Date: Sun, 5 Jul 2009 22:47:36 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv3 1/3] qemu/msi: fix segfault in msix_save
Message-ID: <20090705194735.GB4043@redhat.com>
References: <cover.1246782566.git.mst@redhat.com>
	<20090705102423.GA3833@redhat.com>
	<20090705104516.GA1555@miranda.arrow>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090705104516.GA1555@miranda.arrow>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stuart Brady <sdbrady@ntlworld.com>
Cc: qemu-devel@nongnu.org

On Sun, Jul 05, 2009 at 11:45:17AM +0100, Stuart Brady wrote:
> On Sun, Jul 05, 2009 at 01:24:24PM +0300, Michael S. Tsirkin wrote:
> > +    if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
> > +        return;
> 
> Same bug as fixed by 98846d7 ('Fix Sparse warning').
> 
> Should be:
> 
>     if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) {
>         return;
>     }
> 
> Cheers,

BTW what's the command to run sparse on qemu?

-- 
MST