From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNlNm-0007sp-4P
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 06:25:10 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNlNg-0007rN-L5
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 06:25:09 -0400
Received: from [199.232.76.173] (port=50353 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNlNg-0007rB-C3
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 06:25:04 -0400
Received: from verein.lst.de ([213.95.11.210]:43914)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MNlNf-0008In-KL
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 06:25:04 -0400
Date: Mon, 6 Jul 2009 12:25:00 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] Add new block driver for the VDI format
Message-ID: <20090706102500.GB7835@lst.de>
References: <4A4E5AFC.4020206@mail.berlios.de>
	<1246649386-6006-1-git-send-email-weil@mail.berlios.de>
	<1246649386-6006-2-git-send-email-weil@mail.berlios.de>
	<20090705080523.GA31550@lst.de> <4A50B275.7030100@mail.berlios.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A50B275.7030100@mail.berlios.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Christoph Hellwig <hch@lst.de>, QEMU Developers <qemu-devel@nongnu.org>

On Sun, Jul 05, 2009 at 04:02:29PM +0200, Stefan Weil wrote:
> CONFIG_VDI_UNSUPPORTED and CONFIG_VDI_SNAPSHOT document
> code parts which are still missing or unfinished.
> For the same reason, they are undefined, so the unfinished
> code is deactivated.

> Not having the method would hide the fact that the
> method might be implemented.
> 
> vdi_check is unfinished code, and there is even a comment
> which says that there remains something to do.

Keeping stubs around as a reminder is very bad coding practice.  You
already have a todo list reminding about the missing features on the
top of the file.  Note that the feature set of your vdi driver is the
same as all the other non-native image format drivers, so it's not
really anything special anyway.

> By the way - is it possible to check new block drivers like this one
> using qemu-io (can I use an existing test sequence)?

I've put support into qemu-iotests to run with the vdi format.  It
passes all test that currently are available for vdi.