From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNln5-0005RW-Uk
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 06:51:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNln0-0005Qd-HH
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 06:51:18 -0400
Received: from [199.232.76.173] (port=51640 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNln0-0005Qa-Bu
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 06:51:14 -0400
Received: from verein.lst.de ([213.95.11.210]:44374)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60)
	(envelope-from <hch@lst.de>) id 1MNlmz-0004cA-ON
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 06:51:14 -0400
Date: Mon, 6 Jul 2009 12:51:11 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH] qemu-io: add flag to mark files growable
Message-ID: <20090706105111.GA9469@lst.de>
References: <20090704155330.GA4825@lst.de> <4A51BBA1.4090307@redhat.com>
	<20090706102023.GA7835@lst.de> <4A51D486.10005@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A51D486.10005@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, qemu-devel@nongnu.org

On Mon, Jul 06, 2009 at 12:40:06PM +0200, Kevin Wolf wrote:
> Ok, you are right. raw was the only exception because it could be used
> as a protocol even though it didn't have a protocol name.
> 
> Looks fine to me then if you enforce the limitation instead of only
> printing an error message and opening the image anyway. Not printing the
> error and opening the image would be fine either. I just don't like
> error messages without errors.

Well, the primary use of qemu-iotests is to try out the I/O patterns,
and the -g option is to check out we do the correct thing for growable
files, so I'd really prefer it to fail if we're not allow to actually
make it growable.

Now one think I could do is to just add a growable flag to the
BlockDriver to make it explicit.  Currently only raw files (in the posix
and win32 flavours) would set it.  That would also fix the bug what we
currenly allow to grow host devices even if we can't.