From: Christoph Hellwig <hch@lst.de>
To: Bique Alexandre <alexandre.bique@citrix.com>
Cc: Christoph Hellwig <hch@lst.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 5/5] ATAPI pass through v2: update the configure
Date: Mon, 6 Jul 2009 15:55:00 +0200 [thread overview]
Message-ID: <20090706135500.GA18275@lst.de> (raw)
In-Reply-To: <200907061447.40645.alexandre.bique@citrix.com>
On Mon, Jul 06, 2009 at 02:47:40PM +0100, Bique Alexandre wrote:
> On Sunday 05 July 2009 09:16:37 Christoph Hellwig wrote:
> > On Wed, Jul 01, 2009 at 07:32:04PM +0100, Bique Alexandre wrote:
> > > This patch update the configure by adding --enable-atapi-pt and
> > > --disable-atapi-pt.
> >
> > Do we need an option for this? I'd say we should make it uncoditional
> > when built on Linux like the SCSI passthrough code.
>
> Ok, so I just do:
>
> If Linux then
> enable
> else
> disable
> fi
Yes. Take a look at hw/virtio-blk.c and hw/scsi-generic.c for how we
guard the other pass-through users.
next prev parent reply other threads:[~2009-07-06 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 18:32 [Qemu-devel] [PATCH 5/5] ATAPI pass through v2: update the configure Bique Alexandre
[not found] ` <m3y6r86xfd.fsf@neno.mitica>
2009-07-02 10:36 ` [Qemu-devel] " Bique Alexandre
2009-07-05 8:16 ` [Qemu-devel] " Christoph Hellwig
2009-07-06 13:47 ` Bique Alexandre
2009-07-06 13:55 ` Christoph Hellwig [this message]
2009-07-06 14:33 ` Bique Alexandre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090706135500.GA18275@lst.de \
--to=hch@lst.de \
--cc=alexandre.bique@citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).