From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNofC-0003YG-5Y
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 09:55:22 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNof7-0003Na-Hw
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 09:55:21 -0400
Received: from [199.232.76.173] (port=40342 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNof7-0003NE-7m
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 09:55:17 -0400
Received: from mx20.gnu.org ([199.232.41.8]:6879)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <hch@lst.de>) id 1MNof6-0001BY-IN
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 09:55:16 -0400
Received: from verein.lst.de ([213.95.11.210])
	by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from <hch@lst.de>)
	id 1MNof5-0001x1-BT
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 09:55:15 -0400
Date: Mon, 6 Jul 2009 15:55:00 +0200
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 5/5] ATAPI pass through v2: update the
	configure
Message-ID: <20090706135500.GA18275@lst.de>
References: <200907011932.04493.alexandre.bique@citrix.com>
	<20090705081637.GB32124@lst.de>
	<200907061447.40645.alexandre.bique@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200907061447.40645.alexandre.bique@citrix.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bique Alexandre <alexandre.bique@citrix.com>
Cc: Christoph Hellwig <hch@lst.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Mon, Jul 06, 2009 at 02:47:40PM +0100, Bique Alexandre wrote:
> On Sunday 05 July 2009 09:16:37 Christoph Hellwig wrote:
> > On Wed, Jul 01, 2009 at 07:32:04PM +0100, Bique Alexandre wrote:
> > > This patch update the configure by adding --enable-atapi-pt and
> > > --disable-atapi-pt.
> >
> > Do we need an option for this?  I'd say we should make it uncoditional
> > when built on Linux like the SCSI passthrough code.
> 
> Ok, so I just do:
> 
> If Linux then
> 	enable
> else
> 	disable
> fi

Yes.  Take a look at hw/virtio-blk.c and hw/scsi-generic.c for how we
guard the other pass-through users.