From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MNolt-0007mF-Qd for qemu-devel@nongnu.org; Mon, 06 Jul 2009 10:02:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MNolp-0007kF-RO for qemu-devel@nongnu.org; Mon, 06 Jul 2009 10:02:17 -0400 Received: from [199.232.76.173] (port=51280 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MNolp-0007k2-If for qemu-devel@nongnu.org; Mon, 06 Jul 2009 10:02:13 -0400 Received: from mx20.gnu.org ([199.232.41.8]:7403) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MNolo-0003X7-VC for qemu-devel@nongnu.org; Mon, 06 Jul 2009 10:02:13 -0400 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MNoln-0002N6-Vz for qemu-devel@nongnu.org; Mon, 06 Jul 2009 10:02:12 -0400 Date: Mon, 6 Jul 2009 17:01:29 +0300 From: "Michael S. Tsirkin" Subject: Re: [Qemu-devel] Re: [PATCH 0/4] Machine config files Message-ID: <20090706140129.GB12141@redhat.com> References: <20090610173803.4674.82538.stgit@wren.home> <878wjx374h.fsf@pike.pond.sub.org> <4A3269C3.3050307@redhat.com> <4A327E2C.1060207@siemens.com> <20090706124928.GB11998@redhat.com> <4A51FF7B.4000602@redhat.com> <20090706135616.GA12141@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090706135616.GA12141@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Jan Kiszka , Markus Armbruster , qemu-devel@nongnu.org On Mon, Jul 06, 2009 at 04:56:16PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 06, 2009 at 03:43:23PM +0200, Gerd Hoffmann wrote: > > On 07/06/09 14:49, Michael S. Tsirkin wrote: > >> On Fri, Jun 12, 2009 at 06:11:24PM +0200, Jan Kiszka wrote: > >> Can't we extend loadvm/savevm format to support machine config? It is > >> already supported by all devices, it seems that we just need to add some > >> detail such as pci addresses, and qemu flags to save/load this config. > >> No? > > > > No. Adding some info to the devices doesn't cut it as you also need to > > know which devices are present in the first place. > > Actually at least for pci devices you have the devid/vendor id > register - from this you can know which devices are present. > > > Current savevm > > doesn't do that, thats why you have to start the virtual machine with > > the complete set of command line arguments even when resuming / > > migrating. It seems that it'd be trivial to solve this just by adding a fixed size header telling you which load function to call. No? > > Once we have a working device tree implementation we can fix > > that too though. Rough plan is: > > > > (1) convert drivers to qdev. > > (2) create qdev device tree from config file (probably fdt). > > > > With this in place it is just a little step to also carry this in the > > savevm format: We just need a to do a qdev->fdt conversion, then we can > > send the device tree as one savevm section and rebuild the vm from that. > > > > cheers, > > Gerd