From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MNpGg-0008LQ-LL
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 10:34:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MNpGb-0008K7-2M
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 10:34:05 -0400
Received: from [199.232.76.173] (port=52109 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MNpGY-0008Jv-VQ
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 10:33:59 -0400
Received: from smtp.ctxuk.citrix.com ([62.200.22.115]:49719
	helo=SMTP.EU.CITRIX.COM)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Alexandre.Bique@citrix.com>) id 1MNpGY-0003M9-HP
	for qemu-devel@nongnu.org; Mon, 06 Jul 2009 10:33:58 -0400
From: Bique Alexandre <alexandre.bique@citrix.com>
Subject: Re: [Qemu-devel] [PATCH 5/5] ATAPI pass through v2: update the
	configure
Date: Mon, 6 Jul 2009 15:33:12 +0100
References: <200907011932.04493.alexandre.bique@citrix.com>
	<200907061447.40645.alexandre.bique@citrix.com>
	<20090706135500.GA18275@lst.de>
In-Reply-To: <20090706135500.GA18275@lst.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="Boundary-00=_osgUKESMDzDfp96"
Message-ID: <200907061533.12476.alexandre.bique@citrix.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

--Boundary-00=_osgUKESMDzDfp96
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On Monday 06 July 2009 14:55:00 Christoph Hellwig wrote:
> On Mon, Jul 06, 2009 at 02:47:40PM +0100, Bique Alexandre wrote:
> > On Sunday 05 July 2009 09:16:37 Christoph Hellwig wrote:
> > > On Wed, Jul 01, 2009 at 07:32:04PM +0100, Bique Alexandre wrote:
> > > > This patch update the configure by adding --enable-atapi-pt and
> > > > --disable-atapi-pt.
> > >
> > > Do we need an option for this?  I'd say we should make it uncoditional
> > > when built on Linux like the SCSI passthrough code.
> >
> > Ok, so I just do:
> >
> > If Linux then
> > 	enable
> > else
> > 	disable
> > fi
>
> Yes.  Take a look at hw/virtio-blk.c and hw/scsi-generic.c for how we
> guard the other pass-through users.

I looked at these files and instead of doing

#ifdef __linux__
... code ...
#endif

I propose to do
#ifdef __linux__
# define CONFIG_ATAPI_PT
#endif

in config.h and still do

#ifdef CONFIG_ATAPI_PT
... code ...
#endif

in other source file.

Here is an updated patch.

Thanks.
-- 
Alexandre Bique

--Boundary-00=_osgUKESMDzDfp96
Content-Type: text/x-patch; charset="UTF-8"; name="configure-atapi"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="configure-atapi"

diff --git a/configure b/configure
index eb9d73a..009f210 100755
--- a/configure
+++ b/configure
@@ -1823,6 +1823,12 @@ bsd)
 ;;
 esac
 
+# ATAPI pass through
+cat <<EOF >>$config_h
+#ifdef __linux__
+# define CONFIG_ATAPI_PT 1
+#endif /* __linux__ */
+EOF
 # Determine what linker flags to use to force archive inclusion
 check_linker_flags()
 {

--Boundary-00=_osgUKESMDzDfp96--