qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stuart Brady <sdbrady@ntlworld.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/5] ATAPI pass through v2
Date: Tue, 7 Jul 2009 21:03:27 +0100	[thread overview]
Message-ID: <20090707200327.GA3902@miranda.arrow> (raw)
In-Reply-To: <200907011931.53521.alexandre.bique@citrix.com>

On Wed, Jul 01, 2009 at 07:31:53PM +0100, Bique Alexandre wrote:
> I updated my patch according to your previous comments.
> 
> Changes from my previous version:
>  - split the big patch in 5 patches.
>  - not exporting any private structure
>  - switched to SG_IO and brdv_aio_ioctl()
>  - not including linux/cdrom.h or linux/bsg.h
>  - got some stuff like defines and request_sense structure from linux/cdrom.h

Forgive my ignorance, but does ATAPI passthrough have any security 
implications that should be documented?

I expect that running qemu as root counts as a 'bad idea' (I gather
that commands are filtered when running as a regular user), but even so,
I wonder if guests should be prevented from performing firmware updates?

Obviously, the same questions would apply for SCSI passthrough...

Regards,
-- 
Stuart Brady

  reply	other threads:[~2009-07-07 20:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-01 18:31 [Qemu-devel] [PATCH 0/5] ATAPI pass through v2 Bique Alexandre
2009-07-07 20:03 ` Stuart Brady [this message]
2009-07-07 21:21   ` Alexandre Bique
2009-07-07 22:44     ` Paul Brook
2009-07-07 22:50       ` Alexandre Bique
2009-07-07 23:01         ` Anthony Liguori
2009-07-07 23:15           ` Stuart Brady
2009-07-08 16:09           ` Ian Jackson
2009-07-08 16:38             ` Avi Kivity
2009-07-08 17:28               ` Carl-Daniel Hailfinger
2009-07-08 18:03                 ` Anthony Liguori
2009-07-08 18:09                 ` Avi Kivity
2009-07-08 17:20             ` Anthony Liguori
2009-07-08 17:48               ` Vincent Hanquez
2009-07-08 18:06                 ` Anthony Liguori
2009-07-07 22:58   ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090707200327.GA3902@miranda.arrow \
    --to=sdbrady@ntlworld.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).