From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MOGtg-0007km-Et
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 16:04:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MOGtb-0007iT-7w
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 16:04:11 -0400
Received: from [199.232.76.173] (port=54737 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MOGtb-0007iQ-1I
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 16:04:07 -0400
Received: from mx20.gnu.org ([199.232.41.8]:21622)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <sdbrady@ntlworld.com>)
	id 1MOGta-0008OA-A1
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 16:04:06 -0400
Received: from mtaout01-winn.ispmail.ntl.com ([81.103.221.47])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <sdbrady@ntlworld.com>) id 1MOGt8-0008GS-Vv
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 16:03:39 -0400
Received: from aamtaout03-winn.ispmail.ntl.com ([81.103.221.35])
	by mtaout01-winn.ispmail.ntl.com
	(InterMail vM.7.08.04.00 201-2186-134-20080326) with ESMTP id
	<20090707200329.CCWJ6742.mtaout01-winn.ispmail.ntl.com@aamtaout03-winn.ispmail.ntl.com>
	for <qemu-devel@nongnu.org>; Tue, 7 Jul 2009 21:03:29 +0100
Received: from miranda.arrow ([213.107.24.213])
	by aamtaout03-winn.ispmail.ntl.com
	(InterMail vG.2.02.00.01 201-2161-120-102-20060912) with ESMTP id
	<20090707200329.SOFC2093.aamtaout03-winn.ispmail.ntl.com@miranda.arrow>
	for <qemu-devel@nongnu.org>; Tue, 7 Jul 2009 21:03:29 +0100
Received: from sdb by miranda.arrow with local (Exim 4.63)
	(envelope-from <sdbrady@ntlworld.com>) id 1MOGsy-0001GU-1L
	for qemu-devel@nongnu.org; Tue, 07 Jul 2009 21:03:28 +0100
Date: Tue, 7 Jul 2009 21:03:27 +0100
From: Stuart Brady <sdbrady@ntlworld.com>
Subject: Re: [Qemu-devel] [PATCH 0/5] ATAPI pass through v2
Message-ID: <20090707200327.GA3902@miranda.arrow>
References: <200907011931.53521.alexandre.bique@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200907011931.53521.alexandre.bique@citrix.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

On Wed, Jul 01, 2009 at 07:31:53PM +0100, Bique Alexandre wrote:
> I updated my patch according to your previous comments.
> 
> Changes from my previous version:
>  - split the big patch in 5 patches.
>  - not exporting any private structure
>  - switched to SG_IO and brdv_aio_ioctl()
>  - not including linux/cdrom.h or linux/bsg.h
>  - got some stuff like defines and request_sense structure from linux/cdrom.h

Forgive my ignorance, but does ATAPI passthrough have any security 
implications that should be documented?

I expect that running qemu as root counts as a 'bad idea' (I gather
that commands are filtered when running as a regular user), but even so,
I wonder if guests should be prevented from performing firmware updates?

Obviously, the same questions would apply for SCSI passthrough...

Regards,
-- 
Stuart Brady